I’m having trouble with the puzzle Simplified Monopoly with Kotlin or even Java. I have a success score of 88% on this puzzle as there is one test that doesn’t pass when submitting even if all my tests pass when I’m coding.
I’m pretty sure I didn’t hardcode anything though.
Am I the only one to have some trouble on this matter ?
It looks like your log is for the “Big Run” test (Test 8), instead of for the “Big Run” validator (Validator 8). And your log seems all correct to me.
Please note that tests and validators are similar but different. That means even if your code passes a test, it may not pass the corresponding validator if your code contains a bug which is relevant to the validator only.
It’s worth mentioning that in some puzzles the validators are not representative of the corresponding test case. This means that the input might not be just different values to prevent from hardcoding but actually represent a totally different case scenario. I don’t think there is any strict rule for the community puzzles, even if there one then no one is paying attention during approval. That being said I can’t speak about this particular puzzle.
Is it overstating when I say this is vague? Am I the only one that feels like so? Anyway, this isn’t the issue for me, see below for the real issue.
Each validator must* differ from the corresponding test
It’s only to ensure that the players don’t hardcode the solution.* Sometimes, to cover edge cases, there is no other way than having the same test as validator
There are many puzzles with case scenarios that differ from the test case to the validator. The test scenario/case should be the same only the input data should change values and positioning but I have very often see that validator test cases fail or more often timeout because of the difference of the magnitude/grouping and positioning of the data that will alter the time required. In the worst situations I’ve seen even mixing test scenarios in the validator throwing off the required time to complete. The above guideline is a just general guideline, and I’m not overstating when I say that it doesn’t explain the level of consistency that a test case and its corresponding validator should have.
Sometimes, to cover edge cases, there is no other way than having the same test as validator
I like this, it’s a little bit better but only implicitly trying to convey the same point. It needs more details to address the issue of consistency.
Hasn’t anyone else seen this? or am i too picky?
Can @Kazunil@DooFy explain why the Big Run validator was so off their expectation? Maybe that will tell me if I’m overstating.
I’m simply pointing out that saying “no one is paying attention during approval” is an overstatement. That may be true for this particular puzzle (or perhaps your comment was intended only in the context of this puzzle), but it certainly doesn’t apply to all puzzles.
This is what I said with full context, and I’m going to break it down so everyone will understand better.
I don’t think there is any strict rule for the community puzzles, even if there one then no one is paying attention during approval. That being said I can’t speak about this particular puzzle.
This means that there is no strict guideline.
If there is no strict guideline then it’s fine because that’s where the problem is in the guidelines.
But if there is a strict guideline we can only assume that no one is paying attention because they would have caught all these timeouts during approval. There is practically every other puzzle that people complain about certain validators timing out. So that’s my defense argument on the “no one”.
I understand your reasoning, but my objection is still to the word “no one”. Even if some approvers miss guideline violations, it doesn’t follow that all approvers do. That’s the overstatement I was pointing out.
In any case, this is becoming a discussion about the approval process rather than this puzzle, so I’m happy to continue it in a new thread or via PM if you’d like.
Yes, but you focused on my deliberate exaggeration by replying with a very short statement and you didn’t touch the heart of the issue. Anyway, I don’t usually look at the contributions unless I detect a major foul, even so I try to solve it without snooping. So if you prove me that a single approver has caught such an issue in any of these puzzles I’ll be happy to downgrade from “no one” to “the majority”. Though, even with the downgrade the issue remains in its magnitude.
I think we’re drifting away from the puzzle itself at this point. I’ll send you a PM so we can continue discussing the approval process there without derailing the thread.
Ok so thanks to 5DN1L, I found the problem.
Problem was that after trying 3 times to roll the dice when in prison, I moved the player out of the prison but kept the flag “PRISON” on him so he was out of the prison (when looking at the board) but still considered by my code as “in prison” so he wouldn’t move anyway the next time he plays.
I’ll share below the particular case with a going out of prison after 3 turns that 5DN1L gave to me. (Thanks again for the help )
2
Horse 0
TopHat 0
17
1 3
4 4
1 4
4 4
1 1
5 5
4 4
2 4
2 1
4 3
5 3
3 3
2 5
4 6
6 2
6 5
6 3
Go
Mediterranean Avenue
Community Chest
Baltic Avenue
Income Tax
Reading Railroad
Oriental Avenue
Chance
Vermont Avenue
Connecticut Avenue
Visit Only / In Jail
St. Charles Place
Electric Company
States Avenue
Virginia Avenue
Pennsylvania Railroad
St. James Place
Community Chest
Tennessee Avenue
New York Avenue
Free Parking
Kentucky Avenue
Chance
Indiana Avenue
Illinois Avenue
B. & O. Railroad
Atlantic Avenue
Ventnor Avenue
Water Works
Marvin Gardens
Go To Jail
Pacific Avenue
North Carolina Avenue
Community Chest
Pennsylvania Avenue
Short Line
Chance
Park Place
Luxury Tax
Boardwalk