Fall Challenge 2020 - Bugs & Questions

tutubalin · November 12, 2020, 8:56pm

CRITICAL BUG: when you learn a spell, it becomes repeatable (even if it wasn’t in tome).

Impact:

If you learn a spell that gives ingredients for free, you can repeat it as many times as you want.

Not affected:

Initial spells are not affected.

Proof:

When spell is learnt, only 2 arguments are passed to constructor, repeatable is omitted, so it defaults to true.

github.com

CodinGame/FallChallenge2020/blob/main/src/main/java/com/codingame/game/Game.java#L567



private void doLearn(Player p, TomeSpell spell) throws GameException {
    int index = tome.indexOf(spell);
    if (p.getInventory().delta[0] < index * READ_AHEAD_COST) {
        throw new GameException("Not enough ingredients to learn " + spell.getId());
    }
    for (int i = 0; i < index; ++i) {
        tomeStockGain[i] += READ_AHEAD_COST;
        p.getInventory().delta[0] -= READ_AHEAD_COST;
    }
    PlayerSpell learnt = new PlayerSpell(spell, p);
    p.getSpells().add(learnt);

    int maxToGet = MAX_SPACE - p.getInventory().getTotal();
    int ingredientsGot = Math.min(maxToGet, spell.stock);
    p.getInventory().delta[0] += ingredientsGot;

    learntSpells.add(spell);

    EventData e = new EventData();
    e.type = EventData.LEARN;

github.com

CodinGame/FallChallenge2020/blob/main/src/main/java/com/codingame/game/spell/PlayerSpell.java#L24


    this.active = true;
    this.owner = owner;
    this.repeatable = repeatable;
}

public PlayerSpell(Recipe recipe, Player owner) {
    this(recipe, owner, false);
}

public PlayerSpell(TomeSpell learnt, Player owner) {
    this(new Recipe(learnt.recipe), owner, true);
}

@Override
public boolean isActive() {
    return active;
}

@Override
public boolean isOwner(Player player) {
    return player == owner;